-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read suffix or prefix from file #12
Read suffix or prefix from file #12
Conversation
Thank you for the PR. Actually we do not have documented how to provide a PR. Hence we are going to handle it ad-hoc style. First I suggest to define a dedicated issue and describe there the change. The change should ensure that the validator works as today, even if no property file is defined. You handled that, that's great, but I would silently ignore the nonexistence of the property file, I mean I would not print a message. Furthermore the validator must work from the CLI and from SQL Developer. I'm not sure that using a hardcoded relative path |
…Primus-Delphi-Group/plsql-cop-validators into Read_Suffix_or_Prefix_from_File
* Added a new test for the property-file functionality
All the changes are now in. Please review again :) (Also closes issue #13 when accepted) |
As discussed in #10 :
This adds the functionality to read pre- and suffixes from a .properties file. If none profided it uses the default values.
Open questions from my side (please look at the code first):
First pull request ever for me. So if I am doing stuff wrong just let me know :)