-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general object detection estimator for PyTorch #1295
Conversation
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Codecov Report
@@ Coverage Diff @@
## dev_1.8.0 #1295 +/- ##
=============================================
+ Coverage 80.90% 81.34% +0.43%
=============================================
Files 226 227 +1
Lines 19284 19300 +16
Branches 3499 3502 +3
=============================================
+ Hits 15602 15699 +97
+ Misses 2379 2304 -75
+ Partials 1303 1297 -6
|
This pull request introduces 4 alerts and fixes 1 when merging 8f64dd3 into 07e18ee - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 1 when merging 8f64dd3 into bb5b5c1 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
This pull request introduces 2 alerts and fixes 1 when merging 5579ce6 into bb5b5c1 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
This pull request introduces 1 alert and fixes 3 when merging 66ce420 into bb5b5c1 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Beat, thank you for the review and I have left a few comments!
return self._device | ||
|
||
def _get_losses( | ||
self, x: np.ndarray, y: Union[List[Dict[str, np.ndarray]], List[Dict[str, "torch.Tensor"]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the type hint for x need to be updated as we check several times if x is either an array or a tensor? (similar for later hints as well)
Perhaps also the name and description could be updated as we do not compute the loss here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we don't support torch.Tensor
for x
and checked in line 182, but I agree with you for future releases.
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
This pull request introduces 1 alert and fixes 3 when merging 8271c09 into 56a9fad - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 3 when merging eb1f1cf into 58839f7 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
This pull request introduces 1 alert and fixes 3 when merging 173481f into 58839f7 - view on LGTM.com new alerts:
fixed alerts:
|
Description
This pull request adds a general, model-independent, object detection estimator for PyTorch models in
art.estimators.object_detection.PyTorchObjectDetector
.Fixes #1196
Type of change
Please check all relevant options.