Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Commit

Permalink
🐛 re-add broccoli-clean-css
Browse files Browse the repository at this point in the history
no issue
- `broccoli-clean-css` is used to compress codemirror CSS files so it's still needed
- update usage in `ember-cli-build.js` to match 2.0's class interface
  • Loading branch information
kevinansfield committed Mar 3, 2017
1 parent 89776fb commit 5181852
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
4 changes: 2 additions & 2 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var EmberApp = require('ember-cli/lib/broccoli/ember-app'),
concat = require('broccoli-concat'),
mergeTrees = require('broccoli-merge-trees'),
uglify = require('broccoli-uglify-js'),
cleanCSS = require('broccoli-clean-css'),
CleanCSS = require('broccoli-clean-css'),
environment = EmberApp.env(),
isProduction = environment === 'production',
disabled = {enabled: false},
Expand Down Expand Up @@ -52,7 +52,7 @@ codemirrorAssets = function () {

if (isProduction) {
jsTree = uglify(jsTree);
cssTree = cleanCSS(cssTree);
cssTree = new CleanCSS(cssTree);
}

return mergeTrees([jsTree, cssTree]);
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"blueimp-md5": "2.7.0",
"bower": "1.8.0",
"broccoli-asset-rev": "2.5.0",
"broccoli-clean-css": "^2.0.1",
"broccoli-concat": "3.2.2",
"broccoli-funnel": "1.1.0",
"broccoli-merge-trees": "1.2.1",
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -665,15 +665,6 @@ broccoli-caching-writer@^2.0.4, broccoli-caching-writer@^2.2.0, broccoli-caching
rsvp "^3.0.17"
walk-sync "^0.2.5"

broccoli-clean-css@2.0.1:
version "2.0.1"
resolved "https://registry.yarnpkg.com/broccoli-clean-css/-/broccoli-clean-css-2.0.1.tgz#1bf48a43d7626522621351c696e5f9441f628db2"
dependencies:
broccoli-persistent-filter "^1.2.13"
clean-css-promise "^2.0.1"
json-stable-stringify "^1.0.1"
source-map-to-comment "^1.1.0"

broccoli-clean-css@^1.1.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/broccoli-clean-css/-/broccoli-clean-css-1.1.0.tgz#9db143d9af7e0ae79c26e3ac5a9bb2d720ea19fa"
Expand All @@ -683,6 +674,15 @@ broccoli-clean-css@^1.1.0:
inline-source-map-comment "^1.0.5"
json-stable-stringify "^1.0.0"

broccoli-clean-css@^2.0.1:
version "2.0.1"
resolved "https://registry.yarnpkg.com/broccoli-clean-css/-/broccoli-clean-css-2.0.1.tgz#1bf48a43d7626522621351c696e5f9441f628db2"
dependencies:
broccoli-persistent-filter "^1.2.13"
clean-css-promise "^2.0.1"
json-stable-stringify "^1.0.1"
source-map-to-comment "^1.1.0"

broccoli-concat@3.2.2, broccoli-concat@^3.0.4:
version "3.2.2"
resolved "https://registry.yarnpkg.com/broccoli-concat/-/broccoli-concat-3.2.2.tgz#86ffdc52606eb590ba9f6b894c5ec7a016f5b7b9"
Expand Down

0 comments on commit 5181852

Please sign in to comment.