You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Knex is pinned to 0.8.6 and used inside of this repo purely for testing that the "knexify" adapter is able to convert from GQL to a query builder object and ultimately to the correct SQL.
The tests in this library rely on being able to do require('knex')({}), passing no config, and getting a fallback sql statement that reflects SQLite3, which used to be Ghost's default.
However, in later versions of knex, it is now required to pass in a client, e.g. require('knex')({client: 'sqlite3'}) or require('knex')({client: 'mysql'}).
This means that the tests fail after upgrading.
Using sqlite3 should make the tests work again, but that seems wrong as MySQL is now the default in Ghost. Therefore it seems like there needs to be some restructuring of the tests to make sure that we get the correct output for MySQL and SQLite3.
This is therefore a slightly bigger task than all the other dependency upgrades.
The text was updated successfully, but these errors were encountered:
Knex is pinned to 0.8.6 and used inside of this repo purely for testing that the "knexify" adapter is able to convert from GQL to a query builder object and ultimately to the correct SQL.
The tests in this library rely on being able to do
require('knex')({})
, passing no config, and getting a fallback sql statement that reflects SQLite3, which used to be Ghost's default.However, in later versions of knex, it is now required to pass in a client, e.g.
require('knex')({client: 'sqlite3'})
orrequire('knex')({client: 'mysql'})
.This means that the tests fail after upgrading.
Using sqlite3 should make the tests work again, but that seems wrong as MySQL is now the default in Ghost. Therefore it seems like there needs to be some restructuring of the tests to make sure that we get the correct output for MySQL and SQLite3.
This is therefore a slightly bigger task than all the other dependency upgrades.
The text was updated successfully, but these errors were encountered: