Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

✨ Added drag-and-drop card re-ordering in the editor #1085

Merged
merged 16 commits into from
Dec 17, 2018

Conversation

kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Dec 14, 2018

no issue

  • add vertical drop position indicator handling to koenig-drag-drop-handler service
  • fixed issues with nested drag-and-drop containers
  • register card drag/drop handler in koenig-editor
    • add drag icon creation

TODO:

  • add correct icon for embed and code cards
  • hide card toolbar when dragging
  • fix cursor to default when dragging
  • do not trigger edit mode when dropping a card on itself
  • add br-pill class to the drop indicator
  • show image thumbnail when dragging an image card
  • fix drop indicator not appearing after switching posts
  • fix drop indicator position when first section in post is not a card
  • fix card outline flicker whilst dragging over cards

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 71.357% when pulling a608e06 on kevinansfield:dnd-card-reorder into 58ab778 on TryGhost:master.

@kevinansfield kevinansfield merged commit bc78899 into TryGhost:master Dec 17, 2018
@kevinansfield kevinansfield deleted the dnd-card-reorder branch December 17, 2018 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants