This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Bower => NPM #972
Merged
Bower => NPM #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now that #969 is merged i'll clean this up and get it working completely. |
|
👍 thanks for looking into this, it's been on the back burner for far too long! 😄 |
acburdine
force-pushed
the
bye-bye-bower
branch
from
9b9ebf2
to
a09b5b9
Compare
acburdine
commented
Mar 19, 2018
| @@ -118,6 +118,7 @@ | |||
| "simplemde": "https://github.com/kevinansfield/simplemde-markdown-editor.git#ghost", | |||
| "testem": "2.0.0", | |||
| "top-gh-contribs": "2.0.4", | |||
| "validator": "7.2.0", | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
acburdine
force-pushed
the
bye-bye-bower
branch
from
a09b5b9
to
55ea7ee
Compare
- clean up validator imports - fix validator function imports - remove unused validator extensions
- remove globals imports in favor of direct module imports where possible
kevinansfield
force-pushed
the
bye-bye-bower
branch
from
55ea7ee
to
0aee5cf
Compare
|
Pushed a rebase to fix yarn.lock conflicts |
kevinansfield
added a commit
that referenced
this pull request
Mar 20, 2018
no issue - `validator.js` throws an error if it's `length` method is passed a non-string value - default to passing an empty string if `post.codeInjectionFoot` is falsy (missed in #972)
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Apr 9, 2018
…reen closes TryGhost/Ghost#9543 - TryGhost#972 moved `keymaster` from Bower to NPM but version 1.6.3 is not published to NPM and it contains fixes for unbinding multiple keys (eg, `'down, j': 'moveDown'`). Switched to fetching directly from github to ensure we have the latest version - removed the "has registered shortcuts" guard added in TryGhost#976 - it was working around the buggy keymaster version but was also buggy itself because it meant shortcuts could only be registered the first time a route was loaded even though we unregister all of the shortcuts when leaving the route
kevinansfield
added a commit
that referenced
this pull request
Apr 9, 2018
…reen (#1002) closes TryGhost/Ghost#9543 - #972 moved `keymaster` from Bower to NPM but version 1.6.3 is not published to NPM and it contains fixes for unbinding multiple keys (eg, `'down, j': 'moveDown'`). Switched to fetching directly from github to ensure we have the latest version - removed the "has registered shortcuts" guard added in #976 - it was working around the buggy keymaster version but was also buggy itself because it meant shortcuts could only be registered the first time a route was loaded even though we unregister all of the shortcuts when leaving the route
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #847, requires #969
This PR will remove all bower dependencies, swapping out the ones we can for npm dependencies and removing ones that aren't used at all.
Tasks