🐛 https image urls if accessed over SSL (#8373)

closes #8372

- https image urls if accessed over SSL (fix secure option for images)

core/server/utils/url.js

@@ -259,7 +259,6 @@ function urlFor(context, data, absolute) {
             urlPath = data.image;
             imagePathRe = new RegExp('^' + getSubdir() + '/' + STATIC_IMAGE_URL_PREFIX);
             absolute = imagePathRe.test(data.image) ? absolute : false;
-            secure = data.image.secure;
 
             if (absolute) {
                 // Remove the sub-directory from the URL because ghostConfig will add it back.

core/test/unit/utils/url_spec.js

@@ -240,6 +240,12 @@ describe('Url', function () {
             testData = {image: '/blog/content/images/my-image4.jpg'};
             utils.url.urlFor(testContext, testData).should.equal('/blog/content/images/my-image4.jpg');
             utils.url.urlFor(testContext, testData, true).should.equal('http://my-ghost-blog.com/blog/content/images/my-image4.jpg');
+
+            // Test case for blogs with optional https -
+            // they may be configured with http url but the actual connection may be over https (#8373)
+            configUtils.set({url: 'http://my-ghost-blog.com'});
+            testData = {image: '/content/images/my-image.jpg', secure: true};
+            utils.url.urlFor(testContext, testData, true).should.equal('https://my-ghost-blog.com/content/images/my-image.jpg');
         });
 
         it('should return a url for a nav item when asked for it', function () {