https image urls if accessed over SSL #8373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tentative fix for #8372
kirrg001
suggested changes
Apr 24, 2017
tests whether utils.url.urlFor returns https urls for images over https when blog is configured with a http baseUrl fixes #8372
|
Our blog had optional https but http by default, so it was configured with an http base url. The https version of the rss feed was returning http links for images as the current code only checks the image path for https, ignoring that the actual connection may be https. This PR fixes it. |
kirrg001
reviewed
May 10, 2017
core/server/utils/url.js
Outdated
| @@ -259,7 +259,7 @@ function urlFor(context, data, absolute) { | |||
| urlPath = data.image; | |||
| imagePathRe = new RegExp('^' + getSubdir() + '/' + STATIC_IMAGE_URL_PREFIX); | |||
| absolute = imagePathRe.test(data.image) ? absolute : false; | |||
| secure = data.image.secure; | |||
| secure = data.image.secure || secure; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
pushed a commit
to kirrg001/Ghost
that referenced
this pull request
May 15, 2017
closes TryGhost#8372 - https image urls if accessed over SSL (fix secure option for images)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #8372. I'm not familiar with this codebase so I don't know the rationale behind the current code nor whether this change would be enough, but hopefully will point to the right direction.