Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsecure image links when RSS accessed from HTTPS #8372

Closed
sovietspaceship2 opened this issue Apr 22, 2017 · 4 comments
Closed

Unsecure image links when RSS accessed from HTTPS #8372

sovietspaceship2 opened this issue Apr 22, 2017 · 4 comments
Labels
needs:info [triage] Blocked on missing information server / core Issues relating to the server or core of Ghost

Comments

@sovietspaceship2
Copy link

Probable regression from PR #5189.

When the RSS is accessed over SSL, the title feed links appropriately to https. However, the links to the posts and images still points to http.
@sovietspaceship2 sovietspaceship2 mentioned this issue Apr 22, 2017
Merged
@kirrg001
Copy link
Contributor

Hey @sovietspaceship 👋
Sorry to hear you are having trouble.

Are you experiencing this on Ghost alpha or on 0.11.x?

@kirrg001 kirrg001 self-assigned this Apr 24, 2017
@kirrg001 kirrg001 removed their assignment May 12, 2017
@kirrg001 kirrg001 added server / core Issues relating to the server or core of Ghost help wanted [triage] Ideal issues for contributors to help with labels May 12, 2017
kirrg001 pushed a commit to kirrg001/Ghost that referenced this issue May 15, 2017
@sovietspaceship @kirrg001
🐛 https image urls if accessed over SSL (TryGhost#8373)
4744481 
closes TryGhost#8372

- https image urls if accessed over SSL (fix secure option for images)
@kirrg001 kirrg001 mentioned this issue May 15, 2017
Closed
@kirrg001
Copy link
Contributor

@sovietspaceship Hey again. I just wondered, could you please share your url configuration from your config.js? And could you please share your rss feed? Thanks!

@kirrg001
Copy link
Contributor

Re-open, because we have to investigate/understand this again.

The fix, which was suggested makes in my opinion 100% sense, but i fear that the fix was not really understood from our side, plus it looks like there are other wrong secure flag handlings, see.

This is low priority right now, that's why we would like to spend time next month again.

We have to keep in mind, that we already merged this into master (no big deal, but might be that we want to revert it)

@kirrg001 kirrg001 reopened this Jun 15, 2017
@kirrg001 kirrg001 added the LTS label Jun 15, 2017
@kirrg001 kirrg001 added this to the Upcoming LTS release milestone Jun 15, 2017
@kirrg001 kirrg001 removed the help wanted [triage] Ideal issues for contributors to help with label Jun 15, 2017
@aileen aileen mentioned this issue Jun 22, 2017
Closed
@kirrg001 kirrg001 self-assigned this Jul 14, 2017
@kirrg001 kirrg001 added the needs:info [triage] Blocked on missing information label Sep 8, 2017
@kirrg001 kirrg001 removed their assignment Sep 8, 2017
@kirrg001 kirrg001 removed this from the Upcoming LTS release milestone Sep 8, 2017
@ErisDS
Copy link
Member

ErisDS commented Oct 18, 2017

I don't think we're going to fix this in LTS now, closing.

@ErisDS ErisDS closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:info [triage] Blocked on missing information server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErisDS @kirrg001 @sovietspaceship2