Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site changed webhook not triggered on scheduled content #10226

Closed
m1guelpf opened this issue Nov 30, 2018 · 1 comment · Fixed by #10233
Closed

Site changed webhook not triggered on scheduled content #10226

m1guelpf opened this issue Nov 30, 2018 · 1 comment · Fixed by #10233
Assignees
@rishabhgrg
Labels
affects:api Affects the Ghost API server / core Issues relating to the server or core of Ghost

Comments

@m1guelpf
Copy link
Contributor

Issue Summary

I scheduled an article and, on publish, the webhook didn't get triggered.

To Reproduce

  1. Setup a site-changed webhook
  2. Publish/edit an article to make sure it triggers
  3. Schedule an article
  4. Check the last triggered timestamp on Ghost, or the webhook destination

Technical details:

  • Ghost Version: 2.6.1
  • Node Version: v8.9.4
  • Browser/OS: Ubuntu 16.04.5 LTS
  • Database: mysql
@rishabhgrg
Copy link
Contributor

rishabhgrg commented Dec 3, 2018 •
edited
Loading

@m1guelpf 👋 Thanks for reporting, I can confirm this issue. Scheduled content does not trigger site-changed webhook on publish.

The site-changed event is currently configured to fire only on v2 APIs, while scheduler is still using the old API to update post and does not trigger the webhook. Will work on this as soon as possible, meanwhile moving schedules controller to v2 API is tracked here - #10060

@rishabhgrg rishabhgrg self-assigned this Dec 3, 2018
@rishabhgrg rishabhgrg added the affects:api Affects the Ghost API label Dec 3, 2018
@rishabhgrg rishabhgrg mentioned this issue Dec 3, 2018
Merged
@kirrg001 kirrg001 added the server / core Issues relating to the server or core of Ghost label Dec 3, 2018
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Dec 3, 2018
@rishabhgrg
🐛 Fixed site changed webhook not triggered for scheduled posts
3eeba67 
closes TryGhost#10226

- Middleware emits site-changed event used to trigger webhook, was configured to v2 admin api only.
- Change allows all versions of api to emit event in case of cache invalidation
allouis pushed a commit that referenced this issue Dec 4, 2018
@rishabhgrg @allouis
🐛 Fixed site changed webhook not triggered for scheduled posts
033ddf1 
closes #10226

- Middleware emits site-changed event used to trigger webhook, was configured to v2 admin api only.
- Change allows all versions of api to emit event in case of cache invalidation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabhgrg rishabhgrg

Labels
affects:api Affects the Ghost API server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved event emitter middleware to api app rishabhgrg/Ghost
3 participants
@kirrg001 @rishabhgrg @m1guelpf