Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API V2 complete controller set #10060

Closed
11 of 12 tasks
kirrg001 opened this issue Oct 25, 2018 · 4 comments · Fixed by #10975
Closed
11 of 12 tasks

API V2 complete controller set #10060

kirrg001 opened this issue Oct 25, 2018 · 4 comments · Fixed by #10975
Assignees
@naz
Labels
affects:api Affects the Ghost API server / core Issues relating to the server or core of Ghost

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Oct 25, 2018 •
edited by rishabhgrg

(refs #9866)

There are some controllers missing in V2.
@kirrg001 kirrg001 added server / core Issues relating to the server or core of Ghost affects:api Affects the Ghost API refactoring/cleanup labels Oct 25, 2018
@m1guelpf
Copy link
Contributor

Need help with this? What steps should I take to migrate a controller to the v2 API?

This was referenced Oct 29, 2018
Merged
Merged
@kirrg001
Copy link
Contributor Author

@m1guelpf Thanks for your interest. The Ghost team is working on this issue.
I'd suggest you choose an issue from this list (issues which are labelled with "help wanted" and/or "good-first-issue".

@rishabhgrg rishabhgrg mentioned this issue Oct 30, 2018
Merged
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Nov 2, 2018
@rishabhgrg
Added slack controller to v2
e597451 
refs TryGhost#10060

- Added slack controller to v2 admin API
- Added new API test for slack API controller
naz pushed a commit that referenced this issue Nov 6, 2018
@rishabhgrg @naz
Added slack controller to v2 API (#10086)
3b8621e 
refs #10060

- Added slack controller to v2 admin API
- Added new API test for slack API controller
@rishabhgrg rishabhgrg mentioned this issue Dec 3, 2018
Closed
@kirrg001 kirrg001 mentioned this issue Dec 3, 2018
Merged
@naz naz mentioned this issue Dec 3, 2018
Merged
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Dec 3, 2018
@rishabhgrg
Added configuration controller to v2 API
60afa72 
refs TryGhost#10060
rishabhgrg added a commit that referenced this issue Dec 4, 2018
@rishabhgrg
Added configuration controller to v2 API (#10056)
bf295a9 
refs #10060
@kirrg001 kirrg001 mentioned this issue Dec 17, 2018
Merged
@kirrg001
Copy link
Contributor Author

themes

Working on this.

kirrg001 added a commit that referenced this issue Jan 30, 2019
@kirrg001
Added v2 theme controller
eafbaae 
refs #10060
naz added a commit that referenced this issue May 6, 2019
@naz
Added comment about future scheduler migration
b69f1e9 
refs #10060
kirrg001 pushed a commit to kirrg001/Ghost that referenced this issue May 6, 2019
@naz @kirrg001
Added comment about future scheduler migration
5eaaefd 
refs TryGhost#10060
@naz naz mentioned this issue Jul 10, 2019
Merged
6 tasks
naz added a commit that referenced this issue Jul 17, 2019
@naz
Refactored authentication controller v0.1 (#10893)
4670664 
refs #10060

- Modules extractions done here are meant to make upcoming migration of authentication controller to v2 more manageable and reduce code repetition
- There were couple modules extracted for different areas that controller touches: passwordrest, accept (for invitation), setup 
- The aim was to keep changes to the minimum while making small readability improvements to new functions through async/await syntax
- The biggest barrier to make more encapsulated functions was the fact that we mutate options parameter on multiple levels in the controller. e.g mutations of options.data during validation on the password reset ties it up to the implementation of doReset function
@naz naz mentioned this issue Jul 25, 2019
Merged
2 tasks
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Aug 1, 2019
@rishabhgrg
Refactored oembed controller data validation
634550c 
refs TryGhost#10060

- Uses validation layer for checking url data on oembed requests
- Fixes typo in comment
@rishabhgrg rishabhgrg mentioned this issue Aug 1, 2019
Merged
naz added a commit that referenced this issue Aug 1, 2019
@naz
Migrated authentication controller to v2 (#10950)
27bf453 
refs #10060

- Migrated authentication.resetPassword method to v2
- Migrated authentication.acceptInvitation method to v2
- Migrated authentication.setup method to v2
- Added missing test coverage for "setupUpdate" method
- Migrated authentication.updateSetup method to v2
- Migrated authentication.isInvitation method to v2
- Migrated authentication.isSetup method to v2
- Removed unused 'setup.completed' event as it wasn's used anywhere in the system and has been complicating the logic unnecessarily
- Without the event, it's possible to simplify sendNotification method to just use email address of the user
- Added email sending check to v0.1 test suite
- Refactored sendNotification method to just use email address as parameter
- Renamed sendNotification to sendWelcomeMail
- The only thing the method does now is sending welcome mail, so new naming seems natural :)
rishabhgrg added a commit that referenced this issue Aug 1, 2019
@rishabhgrg
Refactored oembed controller data validation
5f9f5ea 
refs #10060

- Uses validation layer for checking url data on oembed requests
- Fixes typo in comment
@naz naz mentioned this issue Aug 2, 2019
Merged
4 tasks
naz added a commit to naz/Ghost that referenced this issue Aug 7, 2019
@naz
Migrated schedules controller to v2
00f95e7 
closes TryGhost#10060

- Implemented scheduling for posts and pages
- Added cache invalidation when scheduling
- Refactored admin token eneration function to accept existing key as parameter in tests
- Added Ghost Scheduler Integration fixture
- Added fixture for permissions for post publish action
- Migrated getScheduled method to v2
- Did not add support for 'from' and 'to' parameters as they were not used by DefaultScheduler
- This method needs rethinking in a long run as it's an ugly hack and should rather become proper endpoint that returns JSON data instead of models
- Removed unused auth middleware from v2 routes
- Added internal scheduler role
- Implemetnted transactions in v2 frame
- This takes into account scenario mentioned in c93f03b
- Specifically:
>if two queries happening in a transaction we have to signalise
  knex/mysql that we select for an update
  otherwise the following case happens:
  you fetch posts for an update
  a user requests comes in and updates the post (e.g. sets title to "X")
  you update the fetched posts, title would get overriden to the old one
naz added a commit to naz/Ghost that referenced this issue Aug 7, 2019
@naz
Added migrations for scheduler integration, permission and role
532fdb0 
refs TryGhost#10060

- Modification of https://github.com/TryGhost/Ghost/pull/10974/files
- Added publish permission migrations for all roles having "post": "all" permission
@naz naz closed this as completed in #10975 Aug 7, 2019
@rishabhgrg
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naz naz

Labels
affects:api Affects the Ghost API server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Schedules controller migration to v2 naz/Ghost
5 participants
@ErisDS @naz @kirrg001 @rishabhgrg @m1guelpf