Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions for author and contributor need a review and unit test coverage #10234

Closed
1 task
naz opened this issue Dec 3, 2018 · 2 comments
Closed
1 task
Assignees
Labels
affects:api Affects the Ghost API server / core Issues relating to the server or core of Ghost stale [triage] Issues that were closed to to lack of traction

Comments

@naz
Copy link
Contributor

naz commented Dec 3, 2018

This issue is a follow up for #10214 (comment)

We need to review and cover with unit tests the differences between Author and Contributor roles permissions in authors models permissions: https://github.com/TryGhost/Ghost/blob/master/core/server/models/relations/authors.js#L321-L333. Specifically there should be a clarification on whether there's a difference between user being a co-author or a primary author.


Additional tasks:

@naz naz added server / core Issues relating to the server or core of Ghost affects:api Affects the Ghost API permissions labels Dec 3, 2018
@kirrg001
Copy link
Contributor

kirrg001 commented Dec 3, 2018

FYI: We have many, many unit tests in the post_spec.

@naz naz assigned naz and kirrg001 Dec 3, 2018
@kirrg001 kirrg001 removed their assignment Dec 3, 2018
@ErisDS ErisDS added import / upgrade life-cycle stuff: Importing, exporting, upgrading and migrating and removed import / upgrade life-cycle stuff: Importing, exporting, upgrading and migrating labels Jan 24, 2019
@stale
Copy link

stale bot commented Apr 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Apr 24, 2019
@stale stale bot closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:api Affects the Ghost API server / core Issues relating to the server or core of Ghost stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Development

No branches or pull requests

3 participants