🐛Fix access to the common article for multiple editors

[kacperduras]

Fixes #10212
/cc @gargol

[naz]

That was quick @kacperduras, thanks! I'll try to look into this next week 😃 Couple thing that would suggest changing/adding right away:

• following our commit message naming convention
• and adding few unit tests for the bug this change is fixing (you'd need to create a new suite as there have been no unit tests for this module)

Feel free to reach out if you have any questions.

[kacperduras]

Ok, thanks a lot. I haven't got a time in this moment, but tomorrow - no problem :D

[kacperduras]

@gargol

[...] following our commit message naming convention

Fixed.

[...] and adding few unit tests for the bug this change is fixing (you'd need to create a new suite as there have been no unit tests for this module)

Any suggestion for the location of the file?

[rishabhgrg]

Hey @kacperduras 👋

Small fix needed for the commit messages, they need to be in past tense as per the convention, so Fixed in this case. You can also combine these 2 commits into a single commit.

For the location of test file, I'd suggest core/test/unit/models/relations/authors_spec.js as the rest of test folder structure mimics the structure of main file. 😄

[naz]

@kacperduras any progress on the unit tests? 😃

[kirrg001]

@gargol Hey 👋How about

• you double check the requested code changes again
• merge if it looks good to you
• and if a unit test is 100% required and helps avoiding critical bugs, push one test straight to master afterwards (or to this branch) :)

Would love to see this commit in master and in the release tomorrow 👍 🤩👻

[kacperduras]

@gargol Sorry, but I was very busy and I forgot :\ I promise that it will not happen again :)