Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.10.0 Complimentary Subscription no longer works/saves #11648

Closed
uksitebuilder opened this issue Mar 9, 2020 · 2 comments
Closed

3.10.0 Complimentary Subscription no longer works/saves #11648

uksitebuilder opened this issue Mar 9, 2020 · 2 comments
Assignees
@naz
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@uksitebuilder
Copy link

uksitebuilder commented Mar 9, 2020 •
edited
Loading

After upgrading to 3.0.10 and changing membership plan pricing currency to GBP, can no longer give complimentary membership to members

To Reproduce

In admin visit members section
Edit a member that has no pricing plan/subscription yet
Toggle/enable Complimentary Subscription button
Save settings

Following error is returned:

Internal server error, cannot edit member. Cannot read property ‘id’ of undefined

Technical details:

  • Ghost Version: 3.10.0
  • Node Version: 10.19.0
  • Browser/OS: Chrome (latest) macos
  • Database: mySQL 5.7.29 on Ubuntu 18.04
@uksitebuilder uksitebuilder changed the title 3.0.10 Complimentary Subscription no longer works/saves 3.10.0 Complimentary Subscription no longer works/saves Mar 9, 2020
@naz naz added affects:admin Anything relating to Ghost Admin members bug [triage] something behaving unexpectedly labels Mar 10, 2020
@naz naz self-assigned this Mar 10, 2020
@naz
Copy link
Contributor

naz commented Mar 10, 2020

Related issue #11649 (the cause is most likely the same)

naz added a commit to naz/Ghost that referenced this issue Mar 10, 2020
@naz
Cleaned up broken complimentary plan
fd74f30 
refs TryGhost#11648

- Removes Stripe plan entries from settings that are not formatted correctly.
- Incorrect formatting was caused by a bug in 3.10.0 Admin-Client where it wasn't able to find complimentary plan. Related fix for this here - TryGhost/Admin@9e7a6b8
@naz naz mentioned this issue Mar 10, 2020
Merged
naz added a commit that referenced this issue Mar 10, 2020
@naz
Cleaned up broken complimentary plan (#11650)
df05641 
refs #11648

- Removes Stripe plan entries from settings that are not formatted correctly.
- Incorrect formatting was caused by a bug in 3.10.0 Admin-Client where it wasn't able to find complimentary plan. Related fix for this here - TryGhost/Admin@9e7a6b8
@uksitebuilder
Copy link
Author

Reopen please as updating to 3.11.0 did not solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naz naz

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErisDS @naz @uksitebuilder