3.10.0 Can no longer create plans with Stripe after changing currency

[uksitebuilder]

Issue Summary

Changed price symbol to GBP for membership pricing plans

Edited template to add variable for pricing symbol

Symbol does not show

Subscribe button no longer redirects to stripe.

Technical details:

Ghost Version: 3.10.0
Node Version: 10.19.0
Browser/OS: Chrome (latest) macos
Database: mySQL 5.7.29 on Ubuntu 18.04

[uksitebuilder]

Reopen please as updating to 3.11.0 did not solve the issue

[naz]

@uksitebuilder can you please confirm if the migrations to 3.11.0 have run? Also could you provide the values from following query on your mysql instance:

SELECT `value` 
FROM `settings` 
WHERE `key` = 'members_subscription_settings' \G

Please make sure to redact Stripe keys to avoid exposing them.

[uksitebuilder]

I am assuming the migrations have run

Running ghost migrate in ghost-cli returns no migrations needed.

SQL output is as follows:

mysql> SELECT `value` -> FROM `settings` -> WHERE `key` = 'members_subscription_settings' \G; *************************** 1. row *************************** value: {"isPaid":false,"fromAddress":"noreply","allowSelfSignup":true,"paymentProcessors":[{"adapter":"stripe","config":{"secret_token":"sk_live_redacted","public_token":"pk_live_redacted","product":{"name":"My Services"},"plans":[{"name":"Monthly","currency":"gbp","interval":"month","amount":500},{"name":"Yearly","currency":"gbp","interval":"year","amount":5000},{"currency":"gbp"},{"currency":"gbp"},{"currency":"gbp"},{"currency":"gbp"},{"currency":"gbp"}],"currency":"gbp"}}]}

[naz]

To confirm if migration has been run, could you try a following query:

select * from migrations where version = '3.11'

The result should be something like:

mysql> select * from migrations where version = '3.11';
+----+--------------------------------------------------------------+---------+----------------+
| id | name                                                         | version | currentVersion |
+----+--------------------------------------------------------------+---------+----------------+
| 98 | 01-remove-broken-complimentary-plan-from-members-settings.js | 3.11    | 3.10           |
+----+--------------------------------------------------------------+---------+----------------+

[uksitebuilder]

Version and Current Version = 3.11 when running that query

[naz]

3.11 is a correct value, the one I posted was from my dev instance 👍

This is puzzling. The root cause of the bug are those {"currency":"gbp"} values you can see in config.plans[] in members_subscription_settings JSON. The migration should have removed them df05641#diff-699adf57adedebcd9ff7223af7a5a515R45-R47 and the Ghost-Admin fix is making sure these values don't get into the data at any point.

[naz]

@uksitebuilder can you confirm if you have refreshed the "admin" page after running upgrade on the Ghost instance? The only scenario I can think of right now is that the migrations have run but the 3.10.0 version of admin made a request editing the currency 🤔

[uksitebuilder]

Admin was refreshed, caches cleared, even tried running in Incognito mode.

[naz]

The exact steps to fix the issue were given on the community forum