i18n Milestone 3: Wrap all public-facing strings

[daniellockyer]

This issue is part of our community i18n project. The full project is documented on the Ghost forum.

---

✨ We have now started shipping our i18n beta in Ghost, and we're merging community pull requests to add & update languages.

However, not all public-facing strings in Portal and our member emails are currently interpolated for translations. In order to have a full set of translations, we need to ensure all strings are wrapped with the t(..) helper.

How to work on this issue

Setting up

1. Clone the Ghost repository and set up your local environment for development
2. Run yarn dev --portal to get things running at http://localhost:2368/
3. Toggle Enable Portal translations (beta) from http://localhost:2368/ghost/#/settings/labs
4. (optional) Change the Publication Language to make it easier to find uninterpolated strings: http://localhost:2368/ghost/#/settings/general

Wrapping strings

Once you've found a public-facing string from code review or by using Portal/Ghost signup emails, you can easily wrap it so it will be picked up for translation.

1. Add t('..') around the string
   a. You may need to import the t function from the AppContext in Portal
2. Run yarn translate within ghost/i18n to ensure the locale JSON files include the new strings

You can see plenty of examples of how this is currently done using this search query: https://github.com/search?q=repo%3ATryGhost%2FGhost+path%3Aghost%2Fportal+%7Bt%28%27&type=code

Please take extra care to ensure you pass any variables into the t function, and make sure HTML escaping does not cause problems with the output.

Contributing

Commit the changes and submit a PR for us to review and merge 🙂

Be sure to read the contributing guide and reference this issue on the 3rd line of the commit: https://github.com/TryGhost/Ghost/blob/main/.github/CONTRIBUTING.md

---

Thank you to all contributors on the i18n beta so far 🙏🏻

If you speak a language that is not included in our current set of supported languages, please consider submitting it 🌐

[eugene0928]

new language is added

[daniellockyer]

^^ This was inadvertantly closed by the PR but we're basically done here anyway 🙂

[daordonez11]

Hey @daniellockyer quick question could you apply the t(..) helper on email services? Today I found that email template paywall does not support translations and it is a public-facing string.

Ghost/ghost/email-service/lib/email-templates/partials/paywall.hbs

Lines 7 to 8 in bba53b8

	<p style="margin: 0 auto 1.5em auto; line-height: 1.6em; max-width: 440px;">Become a paid member of {{site.title}} to get access to all
	<span style="white-space: nowrap;">subscriber-only content.</span></p>

Is there a way to include translation into this component? I can help with solving that issue. I'm currently trying to work with Ghost(Pro) to build a Spanish newsletter.

[daordonez11]

Hello, @daniellockyer were you able to give this ^ comment a look? I'm not sure if I should create a request in the forum or how to raise this issue.