Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image uploads default to url as though filestorage is set to false #1672

Closed
ErisDS opened this issue Dec 14, 2013 · 2 comments · Fixed by #1675
Closed

Image uploads default to url as though filestorage is set to false #1672

ErisDS opened this issue Dec 14, 2013 · 2 comments · Fixed by #1675
Assignees
@sebgie
Labels
bug [triage] something behaving unexpectedly
Milestone
0.4

Comments

@ErisDS
Copy link
Member

ErisDS commented Dec 14, 2013

This seems to have been caused by #1606

When you go to the editor and try to insert an image, the image uploader shows the url box instead of the dropzone:

no dropzone

This is behaving as though fileStorage is set to false in the config.js file, despite the fact that it is not. Not sure why the changes to express-hbs and our handlebars management is causing this, but I have tested various commits and it seems to be this one causing it.
@sebgie
Copy link
Contributor

sebgie commented Dec 14, 2013

I also see some problems and I think it is related to the lack of registering the helpers (in this case fileStorage) to admin express-hbs. It should be solved with #1640.

@ErisDS
Copy link
Member Author

ErisDS commented Dec 14, 2013

Ah yes, can confirm 👍 assigning this to you and you can close it with your PR :)

@ghost ghost assigned sebgie Dec 14, 2013
sebgie added a commit to sebgie/Ghost that referenced this issue Dec 14, 2013
@sebgie
Improve Helpers
05810b3 
closes TryGhost#1640
closes TryGhost#1672
- changed to include config using require
- deleted has_tag helper
- deleted json helper
- removed fileStorage and ghostScriptTags helpers from frontend
- added fileStorage and url helper to admin
@sebgie sebgie mentioned this issue Dec 14, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebgie sebgie

Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Improve Helpers sebgie/Ghost
2 participants
@ErisDS @sebgie