Bug fixes for partial views #1606
Conversation
|
There are two points where I wonder about my implementation :
So do not hesitate to propose other solutions 😉 |
|
I don't understand why the build fail, because all tests were passed without errors on my side... |
|
Haven't looked at the changes, but I can confirm that the tests for this PR run perfectly fine locally. |
|
Tests have now got a workaround in place, hopefully a rebase will mean travis will pass :) |
|
@ErisDS I think it's ok, I made the rebase (I am not an expert on git, so if something is wrong, tell me). |
|
Absolutely it was a mistake, I just fix it. |
|
So before this PR gets merged it needs to be squashed (instructions here) but I'm afraid that it may also need a bit of a rebase / rework because of other things that have been merged. Hopefully though, it may make more sense to hook this up once ghost.js is dead? |
closes TryGhost#1203 - Update express-hbs module to the new version (0.5.2) - Use two instance of hbs one for the theme and an other for the admin - Template helpers are register as partial view - Partial views of the theme are reload when the theme changed Remove clear partial cache in handlebars This code will be move in `express-hbs`. This doesn't cause a problem to remove this line but it is not clean. Remove unused hbs instance Resolve conflict
|
@ErisDS I think now it's ok, I rebase my PR and clean it in one commit. |
|
This all seems to be working, partials in production mode and everything exciting |
closes #1203
express-hbsmodule to the new version (0.5.2)express-hbsone for the theme and an other for the admin