Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ember.js] Reimplement mobile editor #2957

Closed
ErisDS opened this issue Jun 14, 2014 · 0 comments · Fixed by #3050
Closed

[Ember.js] Reimplement mobile editor #2957

ErisDS opened this issue Jun 14, 2014 · 0 comments · Fixed by #3050
Assignees
@darvelo
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor
Milestone
0.4 Ember.js

Comments

@ErisDS
Copy link
Member

ErisDS commented Jun 14, 2014

Following on from #2426/#2895 we need to also make the editor work on mobile again.

The mobileCodeMirror shim needs porting across to Ember. For now it can load under the same conditions as it did previously, however there are known bugs with this (see #2570) that can be fixed at the same time if the person doing this has a bright idea.

If not - then it should simply load as a replacement editor if the current device is a touchscreen device.
@ErisDS ErisDS added this to the 0.4 Ember.js milestone Jun 14, 2014
This was referenced Jun 14, 2014
Merged
Closed
@ErisDS ErisDS added the mobile label Jun 21, 2014
@ErisDS ErisDS mentioned this issue Jun 24, 2014
Merged
darvelo added a commit to darvelo/Ghost that referenced this issue Jun 24, 2014
@darvelo
Implement Mobile Editor
6658675 
closes TryGhost#2957
- add FastClick library to Gruntfile.js
- add touch-editor to client/assets/lib/
- add mobile-specific utils to util/mobile-utils.js
- add codemirror util to set up TouchEditor only if we're really on mobile
- change gh-codemirror from having a default action to a named action. prevents Ember.TextArea firing action on change
- change gh-codemirror `cm.getDoc().getValue()` to `cm.getValue()` for portability
- change codemirror-shortcuts ES6 export/import style
- changed ghostimagepreview.js to check for Ember.touchEditor in addition to Ghost.touchEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darvelo darvelo

Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor
Projects
None yet
Milestone
0.4 Ember.js
Development

Successfully merging a pull request may close this issue.

Implement Mobile Editor darvelo/Ghost
2 participants
@ErisDS @darvelo