Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users API: deleting users #3100

Closed
ErisDS opened this issue Jun 25, 2014 · 11 comments · Fixed by #3371
Closed

Users API: deleting users #3100

ErisDS opened this issue Jun 25, 2014 · 11 comments · Fixed by #3371
Assignees
Labels
affects:api Affects the Ghost API

Comments

@ErisDS
Copy link
Member

ErisDS commented Jun 25, 2014

JSON API Admin Editor Author NoAuth
users.browse y y y
users.read y y y y
users.edit y y (user == self or user == author) y (user == self)
users.add y y (user == author)
users.delete y (user != owner) y (user == author)

Note, authors cannot delete even their own account.

The flow of deleting a user will include a way to transfer ownership of stuff.

@sebgie
Copy link
Contributor

sebgie commented Jul 1, 2014

I think user.edit and user.delete are not correct yet? Proposal:

JSON API Admin Editor Author NoAuth
users.edit y y (user == self or user == author) y (user == self)
users.delete y (user != owner) y (user == self or user == author)

@ErisDS
Copy link
Member Author

ErisDS commented Jul 1, 2014

Note, authors cannot delete even their own account.

The lack of ability to delete yourself is deliberate. From the perspective of a publishing house, you don't want your authors to throw a wobbly and delete themselves taking a tonne of your content with them.

@sebgie
Copy link
Contributor

sebgie commented Jul 1, 2014

@ErisDS I read that part and didn't propose to change it. The changes are:

  • allow an edtor to edit himself
  • allow an editor to delete himself or an author, the rule in the issue suggests that an editor is allowed to delete admins.

@ErisDS
Copy link
Member Author

ErisDS commented Jul 1, 2014

Sorry I looked too quickly - read change delete and saw user == self against author and thought it was in that row.

I think you are correct about editor editing himself, and that an editor cannot delete admins. Not sure about having editors delete themselves?

@JohnONolan
Copy link
Member

I think the only people who should delete themselves are admins

@sebgie
Copy link
Contributor

sebgie commented Jul 1, 2014

updated table LGTM 👍

@javorszky
Copy link
Contributor

Couple of questoins:

  • What happens to content when an admin deletes itself? Could this potentially lock in parts of Ghost?
  • When transferring ownership, will there be an option to delete all content? (suggestion: no)
  • Who should be able to mass delete content? (owner only or admins? Any admins? Disgruntled employee, or is that none of our business?)

@halfdan
Copy link
Contributor

halfdan commented Jul 2, 2014

IMHO user deletion should perform soft-deletes.
On 2 Jul 2014 10:35, "Gabor Javorszky" notifications@github.com wrote:

Couple of questoins:

  • What happens to content when an admin deletes itself? Could this
    potentially lock in parts of Ghost?
  • When transferring ownership, will there be an option to delete all
    content? (suggestion: no)
  • Who should be able to mass delete content? (owner only or admins?
    Any admins? Disgruntled employee, or is that none of our business?)


Reply to this email directly or view it on GitHub
#3100 (comment).

@ErisDS
Copy link
Member Author

ErisDS commented Jul 2, 2014

This conversation has already been had on #3083 we are not soft deleting, we will transfer content.

@ErisDS
Copy link
Member Author

ErisDS commented Jul 2, 2014

Coming soon: #3182

@ErisDS
Copy link
Member Author

ErisDS commented Jul 2, 2014

@javorszky This is just an API call, it should perform a hard deletion of a user and all related content. Assume that if the content wasn't supposed to be deleted it would already have been moved away by logic / flow in the User interface.

The rules of who can delete what are laid out in the table above, if the user can be deleted, all the content can be deleted too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:api Affects the Ghost API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants