Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor UI - Scroll events are not smooth #481

Closed
ErisDS opened this issue Aug 21, 2013 · 6 comments
Closed

Editor UI - Scroll events are not smooth #481

ErisDS opened this issue Aug 21, 2013 · 6 comments
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@ErisDS
Copy link
Member

ErisDS commented Aug 21, 2013

From #22:

John:

This has become massively laggy/horrible for me - I think due to #297?

Matt:

The debounce stops the 'advanced scrolling' from happening on every scroll event fired. This is probably the reason why it feels laggy. It should improve performance, so it is a case of finding the right amount of timing between each update so it stays visually smooth.

I think we possibly need to switch to throttle, or take the debounce/throttling off entirely if performance is better that way.
@matthojo
Copy link
Contributor

I've been reading about throttle and I think this might be our solution. I'll have a play see what outcomes I get.

@ErisDS
Copy link
Member Author

ErisDS commented Sep 10, 2013

@skattyadz John showed me your PoC for scrolling looked f'in epic. How far from ready is it? Do want! 🍰

@codeincontext
Copy link
Contributor

It needs a little work, but is basically there. Will submit a PR with details later

@codeincontext codeincontext mentioned this issue Sep 11, 2013
Closed
codeincontext added a commit to codeincontext/Ghost that referenced this issue Sep 17, 2013
@codeincontext
Be smarter about how we line up markdown code with the live preview
2f5897b 
Fixes TryGhost#481
Fixes TryGhost#535

Currently we sync these two panes by working out how many % the user is down the left pane, and extending that ratio to the right side. This is good enough for text, but in long posts, or those with elements like images it can go askew.

These changes split both the markdown and the preview into sections (divided by headings). It determines that the user is X percent through section Y, and then applies that same scroll to the other pane.
@JohnONolan
Copy link
Member

Interim solution found - pushing the proper solution exploration to 0.4

@ErisDS ErisDS mentioned this issue Aug 17, 2014
Closed
@JohnONolan
Copy link
Member

This is as good as it's going to get for current editor - and partially fixed by iframe/script placeholders rather than live embeds.

@ErisDS
Copy link
Member Author

ErisDS commented Aug 19, 2014

Closed as wontfix against #1294

@ErisDS ErisDS removed this from the 0.7 Editor milestone Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Be smarter about how we line up markdown code with the live preview codeincontext/Ghost
4 participants
@codeincontext @ErisDS @JohnONolan @matthojo