Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme upload/download #7204

Closed
kirrg001 opened this issue Aug 15, 2016 · 2 comments · Fixed by #7209
Closed

Theme upload/download #7204

kirrg001 opened this issue Aug 15, 2016 · 2 comments · Fixed by #7209
Assignees
@kevinansfield @kirrg001
Labels
affects:admin Anything relating to Ghost Admin feature [triage] New features we're planning or working on server / core Issues relating to the server or core of Ghost
Milestone
0.10.0

Comments

@kirrg001
Copy link
Contributor

Theme upload/download

problem

Adding a new theme for non Ghost(Pro) users requires manual steps on the server - see how to add a theme in ghost. And downloading a theme requires you to login to your server, zip the theme and download the theme for example via ftp or via scp.

Ghost(Pro) users use a separate interface to uploads their themes, which is confusing. There is no option to download themes - you need to contact the support for it.

We would like to change this and offer upload/download functionality within Ghost (via ember).

UI requirements

Right now Ghost offers a dropdown list of all your available themes. You can select the active theme by selecting an item from the dropdown.

We will delete the dropdown list and instead we will add a table of all your available themes.

server requirements

The minimal requirement for the server is to add endpoints for uploading/download the themes.
Using gscan will help us validating a theme.
Later it should be possible to see when a theme was uploaded.
@kirrg001 kirrg001 added themes affects:admin Anything relating to Ghost Admin server / core Issues relating to the server or core of Ghost feature [triage] New features we're planning or working on labels Aug 15, 2016
@kirrg001 kirrg001 added this to the 0.9.1 milestone Aug 15, 2016
@kirrg001 kirrg001 mentioned this issue Aug 16, 2016
Merged
26 tasks
@pascalandy
Copy link

This is much needed to have Ghost considered as a serious contender among it's competitors.
Thanks!

@kevinansfield kevinansfield mentioned this issue Aug 17, 2016
Merged
14 tasks
kirrg001 added a commit to kirrg001/Ghost that referenced this issue Aug 19, 2016
@kirrg001
feature: upload/download themes
ca4cf3a 
closes TryGhost#7204
[ci skip]
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Aug 23, 2016
@kevinansfield
✨ theme management UI
92137ae 
refs TryGhost/Ghost#7204, requires TryGhost/Ghost#7209

- replaces theme dropdown with a table
- adds theme upload modal
    - validates theme mime type
    - prevents upload of `casper.zip` (default Casper theme can't be overwritten)
    - warns if an upload will overwrite an existing theme
    - gives option of immediately activating the uploaded theme or closing after successful upload
- adds theme activation link/action
- adds theme download link/action
- adds theme deletion modal
    - warns about no undo possibility
    - offers possibility to download theme
- modifies mirage config to handle theme changes
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Aug 23, 2016
@kevinansfield
✨ theme management UI
5581c6b 
refs TryGhost/Ghost#7204, requires TryGhost/Ghost#7209

- replaces theme dropdown with a table
- adds theme upload modal
    - validates theme mime type
    - prevents upload of `casper.zip` (default Casper theme can't be overwritten)
    - warns if an upload will overwrite an existing theme
    - gives option of immediately activating the uploaded theme or closing after successful upload
- adds theme activation link/action
- adds theme download link/action
- adds theme deletion modal
    - warns about no undo possibility
    - offers possibility to download theme
- modifies mirage config to handle theme changes
ErisDS pushed a commit that referenced this issue Aug 23, 2016
@kirrg001 @ErisDS
feature: theme upload/download/delete (#7209)
a91e54c 
refs #7204

- added 3 new themes permissions
- change core/client
- add theme upload/download logic
- extended local file storage to serve zips
- added gscan dependency
- add ability to handle the express response within the api layer
- restrict theme upload to local file storage
- added 007 migration
@pascalandy
Copy link

Smells good.

@ErisDS ErisDS mentioned this issue Aug 23, 2016
Merged
ErisDS added a commit to ErisDS/Ghost that referenced this issue Aug 24, 2016
@ErisDS
🎨 Improve theme validation error messaging
73bd332 
refs TryGhost#7204

- Adds a new ThemeValidationError class
- This error has a top level message, but will also contain all the individual errors within the `errorDetails` property
- Updated the API error handling to return `errorDetails` if it is present
kirrg001 pushed a commit that referenced this issue Aug 24, 2016
@ErisDS @kirrg001
🎨 Improve theme validation error messaging (#7253)
02ca986 
refs #7204

- Adds a new ThemeValidationError class
- This error has a top level message, but will also contain all the individual errors within the `errorDetails` property
- Updated the API error handling to return `errorDetails` if it is present
mixonic pushed a commit to mixonic/Ghost that referenced this issue Oct 28, 2016
@kirrg001 @mixonic
feature: theme upload/download/delete (TryGhost#7209)
9ced9a1 
refs TryGhost#7204

- added 3 new themes permissions
- change core/client
- add theme upload/download logic
- extended local file storage to serve zips
- added gscan dependency
- add ability to handle the express response within the api layer
- restrict theme upload to local file storage
- added 007 migration
mixonic pushed a commit to mixonic/Ghost that referenced this issue Oct 28, 2016
@ErisDS @mixonic
🎨 Improve theme validation error messaging (TryGhost#7253)
4abc79c 
refs TryGhost#7204

- Adds a new ThemeValidationError class
- This error has a top level message, but will also contain all the individual errors within the `errorDetails` property
- Updated the API error handling to return `errorDetails` if it is present
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this issue Nov 20, 2016
@kirrg001 @geekhuyang
feature: theme upload/download/delete (TryGhost#7209)
70d96ee 
refs TryGhost#7204

- added 3 new themes permissions
- change core/client
- add theme upload/download logic
- extended local file storage to serve zips
- added gscan dependency
- add ability to handle the express response within the api layer
- restrict theme upload to local file storage
- added 007 migration
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this issue Nov 20, 2016
@ErisDS @geekhuyang
🎨 Improve theme validation error messaging (TryGhost#7253)
81f02b7 
refs TryGhost#7204

- Adds a new ThemeValidationError class
- This error has a top level message, but will also contain all the individual errors within the `errorDetails` property
- Updated the API error handling to return `errorDetails` if it is present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

@kirrg001 kirrg001

Labels
affects:admin Anything relating to Ghost Admin feature [triage] New features we're planning or working on server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

theme upload/download/delete kirrg001/Ghost
3 participants
@kevinansfield @kirrg001 @pascalandy