-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Improve theme validation error messaging #7253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -52,7 +52,8 @@ themes = { | |||
if (error.failures) { | |||
_.each(error.failures, function (childError) { | |||
validationErrors.push(new errors.ValidationError(i18n.t('errors.api.themes.invalidTheme', { | |||
reason: childError.ref | |||
// @TODO use property, or some other mechanism to send & display multiple values here | |||
reason: childError.message + ' (' + childError.ref + ')' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
I will revisit this first thing in the am |
0c4bee2
to
9a605a7
Compare
refs TryGhost#7204 - Adds a new ThemeValidationError class - This error has a top level message, but will also contain all the individual errors within the `errorDetails` property - Updated the API error handling to return `errorDetails` if it is present
9a605a7
to
73bd332
Compare
Note: we should update gscan before the release. For some reason, greenkeeper isn't picking it up. |
LGTM 👍 tested also in browser. |
mixonic
pushed a commit
to mixonic/Ghost
that referenced
this pull request
Oct 28, 2016
refs TryGhost#7204 - Adds a new ThemeValidationError class - This error has a top level message, but will also contain all the individual errors within the `errorDetails` property - Updated the API error handling to return `errorDetails` if it is present
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
refs TryGhost#7204 - Adds a new ThemeValidationError class - This error has a top level message, but will also contain all the individual errors within the `errorDetails` property - Updated the API error handling to return `errorDetails` if it is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7204
errorDetails
propertyerrorDetails
if it is present