Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor freaks out when highlighting large blocks of text #8153

Closed
JohnONolan opened this issue Mar 14, 2017 · 1 comment
Closed

Editor freaks out when highlighting large blocks of text #8153

JohnONolan opened this issue Mar 14, 2017 · 1 comment
Assignees
@disordinary
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@JohnONolan
Copy link
Member

When highlighting text from bottom to top of screen, editor freeks out trying to scroll up / jumping back (can't really tell from the gif due to FPS, but it flickers and goes nuts). Then when cursor is released, toolbar appears in an odd place

uh
@JohnONolan JohnONolan added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor labels Mar 14, 2017
@disordinary
Copy link
Contributor

The Toolbar appears in the middle because as far as the browser is concerned multi line selections are full width, there's not much we can do about that (unless we do some expensive text measuring). Medium has the same behaviour.

We can do something about the scrolling though.

disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
@disordinary
🐜 Bulk selecting
72376aa 
Previously when selecting text in the editor the screen will jump as it tries to scroll so that the cursor is always on it.

This update means it will no longer happen when selecting the text with either the mouse or in a mobile browser. Unfortunately when selecting text with the keyboard the editor will no longer scroll with the cursor.

Closes: TryGhost/Ghost#8153
@disordinary disordinary mentioned this issue Mar 20, 2017
Merged
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
@disordinary
🐜 Bulk selecting
64ddaa3 
Previously when selecting text in the editor the screen will jump as it tries to scroll so that the cursor is always on it.

This update means it will no longer happen when selecting the text with either the mouse or in a mobile browser. Unfortunately when selecting text with the keyboard the editor will no longer scroll with the cursor.

Closes: TryGhost/Ghost#8153
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
@disordinary
🐜 Bulk selecting
b5158ba 
Previously when selecting text in the editor the screen will jump as it tries to scroll so that the cursor is always on it.

This update means it will no longer happen when selecting the text with either the mouse or in a mobile browser. Unfortunately when selecting text with the keyboard the editor will no longer scroll with the cursor.

Closes: TryGhost/Ghost#8153
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Mar 20, 2017
@disordinary @kevinansfield
🐜 Bulk selecting (#594)
98d2394 
closes: TryGhost/Ghost#8153

Previously when selecting text in the editor the screen will jump as it tries to scroll so that the cursor is always on it.

This update means it will no longer happen when selecting the text with either the mouse or in a mobile browser. Unfortunately when selecting text with the keyboard the editor will no longer scroll with the cursor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disordinary disordinary

Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@disordinary @JohnONolan