Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Date must be in the past" error shows up in the publish menu #8359

Closed
kirrg001 opened this issue Apr 19, 2017 · 3 comments · Fixed by TryGhost/Admin#657
Closed

"Date must be in the past" error shows up in the publish menu #8359

kirrg001 opened this issue Apr 19, 2017 · 3 comments · Fixed by TryGhost/Admin#657
Assignees
Labels
affects:admin Anything relating to Ghost Admin
Milestone

Comments

@kirrg001
Copy link
Contributor

I was used to change the publish date for scheduling in the PSM. I found a little bug while playing with both menus to change the publish date.

mustbeinthepast

When i add a date in the future in the PSM and then navigate to the publish menu, i am getting this "Date must be in the past" error message. I can see the same error message, even that the publish date is in the future.

Ghost: master

@kirrg001 kirrg001 added affects:admin Anything relating to Ghost Admin and removed affects:admin Anything relating to Ghost Admin labels Apr 19, 2017
@kevinansfield
Copy link
Contributor

The error you're seeing in the sidebar seems correct - we don't allow future dates to be set there any more, the only way to schedule is via the publish menu.

I can't quite tell what's happening in your screen cap wrt the publish menu, are you able to demonstrate it without clicking outside to close the menu? When closing the menu everything gets reset and unfortunately at the moment the bindings will update immediate and there can be a flash of an error based on the new state before the animation finishes even though there isn't really an error. I need to see if there's a way to reset at the end of the animation.

@kirrg001
Copy link
Contributor Author

The error you're seeing in the sidebar seems correct - we don't allow future dates to be set there any more, the only way to schedule is via the publish menu.

yeah 👍

I can't quite tell what's happening in your screen cap wrt the publish menu, are you able to demonstrate it without clicking outside to close the menu

Then it won't show the error message. The error message only shows if i leave the publish menu.

I need to see if there's a way to reset at the end of the animation.

Yeah sounds like a good idea 👍

@kevinansfield kevinansfield added the affects:admin Anything relating to Ghost Admin label Apr 19, 2017
@kevinansfield kevinansfield added this to the 1.0.0 Launch milestone Apr 19, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 19, 2017
closes TryGhost/Ghost#8359
- if the date/time picker is in an error state when the PSM is closed, reset it to the currently saved time
- resolves the problem with the flash of an error as the publish menu is closed as it's no longer possible to be in a hidden error state
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 19, 2017
closes TryGhost/Ghost#8359
- if the date/time picker is in an error state when the PSM is closed, reset it to the currently saved time
- resolves the problem with the flash of an error as the publish menu is closed as it's no longer possible to be in a hidden error state
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 20, 2017
closes TryGhost/Ghost#8359
- if the date/time picker is in an error state when the PSM is closed, reset it to the currently saved time
- resolves the problem with the flash of an error as the publish menu is closed as it's no longer possible to be in a hidden error state
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue Apr 24, 2017
closes TryGhost/Ghost#8359

- if the date/time picker is in an error state when the PSM is closed, reset it to the currently saved time
- resolves the problem with the flash of an error as the publish menu is closed as it's no longer possible to be in a hidden error state
@markstos
Copy link
Contributor

User experience here could be improved in two ways:

  1. Update the blog post on scheduling posts. It's the number one SEO result for "ghost blog schedule post". It's an official Ghost publication, and it says the way to schedule a post is by setting a future date. https://ghost.org/changelog/scheduled-posts/
  2. Add a tooltip or something to the "Must be in the past" error that that clarifies: "To schedule a post, use the Publish menu."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants