This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🐛 clear date error when closing the PSM #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
force-pushed
the
publishmenu-psm-improvements
branch
from
684debd
to
b760a5f
Compare
kirrg001
suggested changes
Apr 19, 2017
|
Forgot to say: No errors in the debug console. |
closes TryGhost/Ghost#8359 - if the date/time picker is in an error state when the PSM is closed, reset it to the currently saved time - resolves the problem with the flash of an error as the publish menu is closed as it's no longer possible to be in a hidden error state
kevinansfield
force-pushed
the
publishmenu-psm-improvements
branch
from
b760a5f
to
abc624e
Compare
|
@kirrg001 are there any particular circumstances in which you aren't able to open the PSM or is it everywhere? New/old posts, only certain posts? I'm not able to replicate to investigate unfortunately |
|
Will try again and see if i can share steps to reproduce. |
|
I just got this behaviour on my branch #661 as well. So it's not related to this branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8359