-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to upload+reload routes.yaml #9744
Comments
Endpoints: I am following the convention of our redirect uploads.
|
Alternative is
The Maybe it's better to stay consistent for now and use this route notation. |
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
@kirrg001 PR for the UI is here, I've also created a 2.0 branch in Ghost-Admin with this commit already merged. Code is completely untested so far because I couldn't see that the endpoints were implemented anywhere yet 😄 |
refs TryGhost#9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
This issue can be closed. All tasks are done. Final QA/testing will happen soon. |
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
refs TryGhost/Ghost#9744 - adds `routes.yaml` upload using the same UI as the `redirects.json` upload - upload: `POST /settings/routes/yaml/` - download: `GET /settings/routes/yaml/`
refs #9744 - added two new endpoints to upload/download routes.yaml - reload site express app on successful/valid upload - reload url service on sucessfuly upload - force clear cache of pages - ensure we keep a backup of the routes.yaml file - this feature was mostly tested manually - @todo: i have to write unit tests - will do later - @todo: do a memory test to ensure we haven't introduced any memory leaks with this feature
We haven't announced Dynamic Routing Beta yet, but you can already read through this issue and read what Dynamic Routing is and how it works 🤠
We would like to add the ability to upload the routes.yaml file in the admin panel. We will add a new form under
Labs
(very similar to the redirects upload form).When the file was successfully uploaded, Ghost will reload all site routes based on your new routes.yaml version/file. A server restart won't be required.
This sub-feature will be available in Ghost 2.0.
Tasks
The text was updated successfully, but these errors were encountered: