Authentication controller v2 migration

[naz]

refs #10060

Work in progress. But all methods are moved already.

One change think is worth doing while at this stage is splitting this authentication controller into more natural pieces - setup, invitations (we already have invites controller) and passwordreset. Although they partially fit under the same 'authentication' umbrella, think it's worth to break the authentication controller further for couple reasons:

1. It is touching different areas
2. Having to use custom docName: 'authentication' under most endpoints
3. Having too many methods in a single controller

The other bit is the naming of endpoints. Currently, these are:

router.post('/authentication/passwordreset', ..., api.http(apiv2.authentication.generateResetToken));
router.put('/authentication/passwordreset', ..., api.http(apiv2.authentication.resetPassword));
router.post('/authentication/invitation', api.http(apiv2.authentication.acceptInvitation));
router.get('/authentication/invitation', api.http(apiv2.authentication.isInvitation));
router.post('/authentication/setup', api.http(apiv2.authentication.setup));
router.put('/authentication/setup', ..., api.http(apiv2.authentication.updateSetup));
router.get('/authentication/setup', api.http(apiv2.authentication.isSetup));

To me it feels like simplifying it down to plain names like /passwordreset/ without /authentication/ prefix would make sense?

@kevinansfield @allouis would love to hear your thoughts on the above 💃

Todo:

• manual testing
• probable controller breakdown to multiple pieces

[naz]

@allouis @kevinansfield ping 😉

[allouis]

This all looks good to me!

1. Naming - I don't have any opinion on this either way tbh 🤷‍♂️

2. Splitting the controller out - I personally think we don't need to - it's not crazy big yet.

IMO this is good to merge as is 👍

[kevinansfield]

LGTM 👍

To me it feels like simplifying it down to plain names like /passwordreset/ without /authentication/ prefix would make sense?

I don't think we should change anything at the moment especially as it would be a breaking change for v2. It's worth thinking about a little for v3 but I don't think it's a pressing need, namespacing under /authentication/ helps keep the top-level namespace clearer 🤔

One change think is worth doing while at this stage is splitting this authentication controller into more natural pieces

It's fine as it is I think, these are (and should be) rarely changing bits of code and it's useful to see all endpoints for the setup/invite/signup flow together. I do get your point though, we can look at refactoring+splitting if it starts to cause pain.