Added support for secondary navigation #11409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naz
reviewed
Nov 21, 2019
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| {{#if isHeader}}isHeader is set{{/if}} | |||
|
|
|||
| {{#if isSecondary}}Jeremy Bearimy baby!{{/if}} | |||
|
FYI I know this isn’t quite done yet - wanted to open it to get feedback on the ember part 😅 |
ErisDS
force-pushed
the
secondary-nav
branch
2 times, most recently
from
f56a2b7
to
a1f0798
Compare
- Secondary navigation means most nav concepts are supported, e.g. header & footer, or left & right - The UI is added separately, this PR adds supporting concepts: - make sure the default value is an empty array - add support in the API (v3 only) - add handling in the navigation helper
ErisDS
force-pushed
the
secondary-nav
branch
from
a1f0798
to
e7a72fc
Compare
naz
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Dec 4, 2019
refs: TryGhost/Ghost#11409 - Added a new UI for a second set of navigation links - This should support most concepts of nav, e.g. left and right, or header and footer - This PR mostly updates the design and nav components to cope with a second set of nav
naz
pushed a commit
to TryGhost/Casper
that referenced
this pull request
Dec 4, 2019
refs TryGhost/Ghost#11409 - Adds secondary navigation to the main menu - Updated secondary nav mobile styles - Updated cover for the scrollable main navigation
guillaume-sainthillier
pushed a commit
to silarhi/Casper
that referenced
this pull request
Mar 29, 2021
refs TryGhost/Ghost#11409 - Adds secondary navigation to the main menu - Updated secondary nav mobile styles - Updated cover for the scrollable main navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
{{navigation type="secondary"}}Inside a navigation.hbs: