Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ improved support config mail domain setting #11474

Closed
wants to merge 1 commit into from
Closed

✨ improved support config mail domain setting #11474

wants to merge 1 commit into from

Conversation

Jordan-Hall
Copy link

@Jordan-Hall Jordan-Hall commented Dec 19, 2019

Ref: #11414
This PR relates to TryGhost/Admin#1432

Change functionality of the fromAddress and added domain option in the config. This allows members to read from a single point

@Jordan-Hall Jordan-Hall changed the title �:art: improved support config mail domain setting ✨ improved support config mail domain setting Dec 19, 2019
@naz
Copy link
Contributor

naz commented Jan 7, 2020

Note: if we go with this solution would need to update the CLI to accept the domain option through an option similar to --mailhost (ref. https://ghost.org/docs/api/v3/ghost-cli/config/#options). But let's discuss the approach on the forum first 😉

@naz naz mentioned this pull request Jan 9, 2020
@naz
Copy link
Contributor

naz commented Jan 9, 2020

Closing this PR for now to keep the PR list clean. It might get reopened if this solution is considered in the future. Thanks again for the contribution @Jordan-Hall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants