✨ Members background importer #12472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-issue We are rewriting the Members CSV importer to use background jobs, the batched importer will no longer be used locally.
no-issue The new import flow does not use prevalidation of the CSV file, so we have no use for this anymore.
no-issue This will be used to generate email content used for notifying users that their import has been completed.
no-issue This module encapsulates the work around performing imports, it currently uses the concept of a "Job" which at the moment is not persisted to the database, however when we want to look at resuming imports after a server restart, this should give us the flexibility to do it.
no-issue This will allow the controller to be updated to use the new importer
no-issue - Updates members-api to throw errors when attempting to link to stripe customers if it is not configured, which allows us to include the errors in the CSV - Updates members-csv to handle the header mappings as well as parsing the values so that we can read a CSV file and get back valid member objects
no-issue This completely replaces the old import functionality with the new importer!
allouis
force-pushed
the
members-importer-rc
branch
from
e63b2f3
to
a9df6ff
Compare
rishabhgrg
added a commit
to TryGhost/Admin
that referenced
this pull request
Dec 9, 2020
no refs depends on TryGhost/Ghost#12472 The members CSV importer gets an overhaul and works with new importer module in members service, performing the import in a background job when the import will take too long to complete in a reasonable time and send an email with data on completion. Also includes updated CSV mapping UI and error handling to allow easier import from different type of exports. Co-authored-by: Fabien O'Carroll <fabien@allou.is> Co-authored-by: Peter Zimon <zimo@ghost.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-issue
This adds a new importer module to the members service, and updates the canary API to use this importer, performing the import in a background job when the import will take too long to complete in a reasonable time