Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): add cache to workflows using actions/setup-node #13597

Closed
wants to merge 1 commit into from
Closed

ci(workflow): add cache to workflows using actions/setup-node #13597

wants to merge 1 commit into from

Conversation

oscard0m
Copy link
Contributor

Description

Add cache to workflows using actions/setup-node

Context

setup-node GitHub Action just released a new option to add cache to steps using it.

You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/


🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@daniellockyer
Copy link
Member

@oscard0m Thank you for the PR! A couple of things:

  1. Can you rebase on top of main so the tests pass?
  2. Can you reduce the PR down to the core change here? ie. just adding the cache key and not changing quotes/indentation. Also note that we use yarn and not npm in tests 🙂

@oscard0m
Copy link
Contributor Author

oscard0m commented Nov 3, 2021

@oscard0m Thank you for the PR! A couple of things:

  1. Can you rebase on top of main so the tests pass?

  2. Can you reduce the PR down to the core change here? ie. just adding the cache key and not changing quotes/indentation. Also note that we use yarn and not npm in tests 🙂

Sure! I will try to address this during this week. Thanks for the feedback and sorry for the quotes and wrong cache params. It is something to fix in my script

@daniellockyer
Copy link
Member

All good! Ping me when it's done and I'll merge 🕺🏻

@oscard0m
Copy link
Contributor Author

oscard0m commented Nov 6, 2021

Moved to #13716

@oscard0m oscard0m closed this Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants