馃帹 Improved search keywords in Admin-X Settings #18608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - improves search results in adminx settings - e.g. when searching for "code injection" no results were returned - makes sure that all user-facing labels are referenced by the searchKeywords
|
Thanks for the contribution! I'll take a proper look early next week and double check these all match our intention with search, but this looks great! |
3 tasks
daniellockyer
changed the title
|
Thanks @betschki! 馃檪 |
3 tasks
daniellockyer
pushed a commit
that referenced
this pull request
Oct 24, 2023
- this builds upon #18608 - related to a discussion in the Ghost forum here: https://forum.ghost.org/t/searching-the-new-ui-bug/42043/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 馃帄!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)We appreciate your contribution!
馃 Generated by Copilot at b1ece9b
Moved and updated the search keywords for the settings sections from their respective component files to the
AdvancedSettings.tsxfile. This was part of a refactoring to consolidate the settings components and to improve the searchability of the settings options.