Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added individual settings fields to search keywords #18704

Merged

Conversation

betschki
Copy link
Contributor

The goal of this commit is to make all the individual setting fields searchable by adding them to the keywords. This should significantly improve UX when trying to look for "comments", for example, which one might not suspect to be paired with "Access" settings in memberships.

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

no issue

- The goal of this commit is to make all the individual setting fields searchable by adding them to the keywords. This should significantly improve UX when trying to look for "comments", for example, which one might not suspect to be paired with "Access" settings in memberships.
@betschki
Copy link
Contributor Author

This builds upon #18608 and is related to a discussion in the Ghost forum here: https://forum.ghost.org/t/searching-the-new-ui-bug/42043/2

@daniellockyer daniellockyer changed the title 🎨 add individual setting fields to search keywords Added individual settings fields to search keywords Oct 24, 2023
@daniellockyer daniellockyer merged commit 1af8d58 into TryGhost:main Oct 24, 2023
15 checks passed
@daniellockyer
Copy link
Member

Thanks @betschki! 🙂

@betschki betschki deleted the improve-setting-search-keywords branch October 25, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants