Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fixed members events for archived newsletters #19638

Merged
merged 4 commits into from
Feb 1, 2024
Merged

馃悰 Fixed members events for archived newsletters #19638

merged 4 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. 馃悰 Fixed members events for archived newsletters 

    fixes https://linear.app/tryghost/issue/ENG-604/馃悰-members-events-show-member-subscribed-to-archived-newsletter

- Members Subscribe events are being created from Archived newsletters
  that the Member may have subscribed to in the past prior to the
newsletter being archived.
- This fixes a bug where it doesn't take that into account and would
  create an Event for subscribing back to those newsletters even though
its not the case, which causes some confusion for publishers in Member
Events.
    @ronaldlangeveld
    ronaldlangeveld committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f423d01 View commit details
    Browse the repository at this point in the history

  2. Cleaned up comments

    @ronaldlangeveld
    ronaldlangeveld committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    2cd6698 View commit details
    Browse the repository at this point in the history

  3. Simplified code

    @ronaldlangeveld
    ronaldlangeveld committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    88594cd View commit details
    Browse the repository at this point in the history

  4. Removed old comments

    @ronaldlangeveld
    ronaldlangeveld committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a47c126 View commit details
    Browse the repository at this point in the history