馃悰 Fixed members events for archived newsletters #19638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes https://linear.app/tryghost/issue/ENG-604/馃悰-members-events-show-member-subscribed-to-archived-newsletter - Members Subscribe events are being created from Archived newsletters that the Member may have subscribed to in the past prior to the newsletter being archived. - This fixes a bug where it doesn't take that into account and would create an Event for subscribing back to those newsletters even though its not the case, which causes some confusion for publishers in Member Events.
ronaldlangeveld
requested review from
SimonBackx
and removed request for
allouis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/tryghost/issue/ENG-604/馃悰-members-events-show-member-subscribed-to-archived-newsletter