Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oAuth #3060

Merged
merged 1 commit into from
Jun 30, 2014
Merged

oAuth #3060

merged 1 commit into from
Jun 30, 2014

Conversation

sebgie
Copy link
Contributor

@sebgie sebgie commented Jun 24, 2014

closes #2759
closes #3027

  • added oauth2orize library for server side oAuth handling
  • added ember-simple-auth library for admin oAuth handling
  • added tables for client, accesstoken and refreshtoken
  • implemented RFC6749 4.3 Ressouce Owner Password Credentials Grant
  • updated api tests with oAuth
  • removed session, authentication is now token based

Known issues:

Attention

  • oldClient doesn't work with this PR anymore, session authentication was
    removed

ErisDS added a commit to ErisDS/Ghost that referenced this pull request Jun 26, 2014
ref TryGhost#3060

- Some of our tests use the old signin/signout as part of the setup/teardown process. The old stuff is going away, so this PR switches everything over to use the new admin by default.
- There wil be a further PR to remove the old stuff completely soon.
@ErisDS
Copy link
Member

ErisDS commented Jun 27, 2014

My updates to the tests have been merged. If you rebase, you should be able to comment out the remaining failing tests with a TODO and the issue tag for the tasks opened up yesterday?

That way we can potentially get this in.

@ErisDS
Copy link
Member

ErisDS commented Jun 27, 2014

A quick note to add a closes tag for issue #3027 to the commit ref

@sebgie sebgie changed the title [WIP] oAuth oAuth Jun 27, 2014
@sebgie
Copy link
Contributor Author

sebgie commented Jun 27, 2014

Updated

closes TryGhost#2759
closes TryGhost#3027

- added oauth2orize library for server side oAuth handling
- added ember-simple-auth library for admin oAuth handling
- added tables for client, accesstoken and refreshtoken
- implemented RFC6749 4.3 Ressouce Owner Password Credentials Grant
- updated api tests with oAuth
- removed session, authentication is now token based

Known issues:
- Restore spam prevention TryGhost#3128
- Signin after Signup TryGhost#3125
- Signin validation TryGhost#3125

**Attention**
- oldClient doesn't work with this PR anymore, session authentication
was
removed
ErisDS added a commit that referenced this pull request Jun 30, 2014
@ErisDS ErisDS merged commit feb1cd1 into TryGhost:master Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ember.js] Session expiry is not handled [Ember.js] Authentication with OAuth
3 participants