Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup / tabindex / consistency fixes #5726

Merged
merged 2 commits into from Aug 26, 2015

Conversation

@ErisDS
Copy link
Member

commented Aug 25, 2015

refs #5652

Fixes:

Pressing "tab" after the last input field takes keyboard focus to address bar. Should be: submit button.

Providing that this option is chosen in safari:

This is WIP because there are more places I'd like to test / check this yet - just getting it open to show progress.

A couple of questions:

  • Are the consistency changes wanted? I think using a block helper for gh-spin-button, makes more sense / is easier to read, but not sure what the ember take on this is. Also I think it makes sense not to include 'type="button"' when that is the default.
  • Where buttons are submit button near a form (e.g. on setup/two and setup/three) should they not be inside the form? I thought that was normal from a markup perspective, but maybe it makes styling hard?

What's in the box:

  • ensure gh-spin-button passes type & tabindex through to markup
  • add gh-input class to auto focus input
  • add tabindexes to setup/two + make first field autofocus and button submit
  • always put button text inside opening/closing helper tag
  • only include type if it is 'submit' as button is default
  • wrap attributes in double quotes
@JohnONolan

This comment has been minimized.

Copy link
Member

commented Aug 26, 2015

👍

@ErisDS ErisDS force-pushed the ErisDS:forms-tab branch Aug 26, 2015

ErisDS added 2 commits Aug 25, 2015
Improve markup + tabindex etc on setup/two
refs #5652

- ensure gh-spin-button passes type & tabindex through to markup
- add gh-input class to auto focus input
- add tabindexes to setup/two + make first field autofocus and button submit
Spin button consistency
refs #5652

- always put button text inside opening/closing helper tag
- only include type if it is 'submit' as button is default
- wrap attributes in double quotes

@ErisDS ErisDS force-pushed the ErisDS:forms-tab branch to b0fbd1b Aug 26, 2015

kevinansfield added a commit that referenced this pull request Aug 26, 2015
Merge pull request #5726 from ErisDS/forms-tab
[WIP] Markup / tabindex / consistency fixes

@kevinansfield kevinansfield merged commit 0c4cc67 into TryGhost:master Aug 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ErisDS ErisDS changed the title [WIP] Markup / tabindex / consistency fixes Markup / tabindex / consistency fixes Aug 26, 2015

@kevinansfield kevinansfield deleted the ErisDS:forms-tab branch Aug 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.