Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small cleanup / refactor which is a precursor to a bigger one for migrations. Doing this adds some ground work for testing other bits and pieces in migrations.
The main piece, other than the cleanup of the export code, is the change to the knex getter - setting
configurable
to be true rather than false, otherwise it is not possible to stub this method. IMO testability is more important here.Two other changes are present:
refs #6301
doExport
function consistent with import & easier to test