Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter cleanup & tests #6596

Merged
merged 1 commit into from Mar 13, 2016
Merged

Exporter cleanup & tests #6596

merged 1 commit into from Mar 13, 2016

Commits on Mar 12, 2016

  1. Exporter cleanup & tests

    refs TryGhost#6301
    
    - change knex getter def to be configurable, else it is not testable
    - remove exportPath and lang from config - neither are used
    - add client_trusted_domains to tables which shouldn't be exported as there are no clients in the export
    - change export signature to be an object with `doExport` function consistent with import & easier to test
    - cleanup export code so it is clearer, easier to read & to test:
      - use mapSeries instead of sequence
      - use Promise.props instead of Promise.join
      - split functionality into smaller functions
    - add test coverage
    ErisDS committed Mar 12, 2016
    Configuration menu
    Copy the full SHA
    9309adc View commit details
    Browse the repository at this point in the history