New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared references in ValidationEngine #6756

Merged
merged 1 commit into from Apr 26, 2016

Conversation

Projects
None yet
2 participants
@kevinansfield
Contributor

kevinansfield commented Apr 25, 2016

no issue

  • ensure that each object instance using the ValidationEngine mixin gets it's own errors and hasValidated objects
  • updates some uses of ValidationEngine that were relying on side-effects of the unintended reference sharing
  • fixes issue with add subscriber modal displaying an error state after opening if it previously had errors when closing
Don't share errors and hasValidated references between validator inst…
…ances

no issue
- ensure that each validator instance gets it's own `errors` and `hasValidated` objects
- updates some uses of `ValidationEngine` that were relying on side-effects of the unintended reference sharing
- fixes issue with add subscriber modal displaying an error state after opening if it previously had errors when closing

@ErisDS ErisDS merged commit 452664a into TryGhost:master Apr 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ErisDS ErisDS deleted the kevinansfield:fix-validation-engine-shared-refs branch Apr 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment