Don't populate settings defaults twice on startup

[acburdine]

Slight regression that throws an error whenever a new setting is added. (only on the first boot of the blog, doesn't happen after that).

To reproduce the error (without this PR):

1. Clear the SQLite DB
2. Checkout commit 77464c5
3. Start & setup blog
4. Checkout master
5. Start blog and see a SQLite constraint error

With these changes that doesn't happen.

[ErisDS]

This change causes the default settings to only be populated if there's a migration, and not in every other case?

[ErisDS]

Wait no, the way the code was collapsed was super confusing.

[acburdine]

So this is good?

[acburdine]

Oops, seems to be a bit of a test bug 😛

[kirrg001]

i don't think this fix solves the underlying problem.
the populateDefaults fn tries to insert in this case the new property seenNotifications, because require('../data/schema/').defaultSettings discovers "oh yeah there is a new default setting to insert". In my opinion we should extend error handling to ensure: if we insert a key, which already exists in the database settings table, we could either update the key or ignore the error

[acburdine]

Fair enough. I feel like removing the first settings populate call is still necessary though.

[kirrg001]

i think we need the call, because migrations.update happens in parallel.
So it does

1. getDatabaseVersion
2. calls migrations.update (parallel, there is no return)
3. but jumps directly to populate the settings, because the blog should already start

[kevinansfield]

@acburdine it seems there's a test failure with the re-created branch 😞

[acburdine]

@kevinansfield fixed it