-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme upload/download/delete #7209
theme upload/download/delete #7209
Conversation
4842379
to
ee13f7e
Compare
7e37f3f
to
3460c8e
Compare
9664e3f
to
3967048
Compare
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
3979daf
to
41d117b
Compare
[ci skip]
41d117b
to
4cb9f06
Compare
4cb9f06
to
615a4f7
Compare
// CASE: serve themes | ||
// serveStatic can't be used to serve themes, because | ||
// download files depending on the route (see `send` npm module) | ||
if (options.isTheme) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
ready for review. i kept the history of commits, but i would recommend reading the full diff, because it's not a lot to read and 50% are tests 🎉 |
resource = 'theme'; | ||
|
||
function getPermissions() { | ||
return utils.findModelFixtures('Permission', {object_type: resource}); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
refs TryGhost/Ghost#7204, requires TryGhost/Ghost#7209 - replaces theme dropdown with a table - adds theme upload modal - validates theme mime type - prevents upload of `casper.zip` (default Casper theme can't be overwritten) - warns if an upload will overwrite an existing theme - gives option of immediately activating the uploaded theme or closing after successful upload - adds theme activation link/action - adds theme download link/action - adds theme deletion modal - warns about no undo possibility - offers possibility to download theme - modifies mirage config to handle theme changes
refs TryGhost/Ghost#7204, requires TryGhost/Ghost#7209 - replaces theme dropdown with a table - adds theme upload modal - validates theme mime type - prevents upload of `casper.zip` (default Casper theme can't be overwritten) - warns if an upload will overwrite an existing theme - gives option of immediately activating the uploaded theme or closing after successful upload - adds theme activation link/action - adds theme download link/action - adds theme deletion modal - warns about no undo possibility - offers possibility to download theme - modifies mirage config to handle theme changes
refs TryGhost#7204 - added 3 new themes permissions - change core/client - add theme upload/download logic - extended local file storage to serve zips - added gscan dependency - add ability to handle the express response within the api layer - restrict theme upload to local file storage - added 007 migration
refs TryGhost#7204 - added 3 new themes permissions - change core/client - add theme upload/download logic - extended local file storage to serve zips - added gscan dependency - add ability to handle the express response within the api layer - restrict theme upload to local file storage - added 007 migration
closes #7204
Upload, download and delete themes within Ghost.
TODO's
core/server/api/utils.js
theme.zip