Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洜 update lodash,knex and bookshelf to latest versions #7456

Merged

Conversation

kirrg001
Copy link
Contributor

refs #7189

This is a LTS support PR. We already merged this change into master, see #7402.

We had a memory leak after upgrading to bookshelf 0.10.1.
Bookshelf has fixed the memory leak in 0.10.2.

This PR contains version bumps for knex, bookshelf and lodash.

refs TryGhost#7189
- we had a memory leak after upgrading to knex 0.11.x
- knex has published a new version 0.12.x
- the memory leak does not longer exists
- knex has reverted their pool logic, see knex/knex#1665
@kirrg001 kirrg001 added the LTS label Sep 29, 2016
@ErisDS ErisDS merged commit 0ea814e into TryGhost:lts Sep 29, 2016
@ErisDS
Copy link
Member

ErisDS commented Sep 29, 2016

Thanks @kirrg001 馃嵃

@ErisDS ErisDS removed the LTS label Oct 7, 2016
yo1dog pushed a commit to yo1dog/Ghost that referenced this pull request Oct 14, 2016
refs TryGhost#7189
- we had a memory leak after upgrading to knex 0.11.x
- knex has published a new version 0.12.x
- the memory leak does not longer exists
- knex has reverted their pool logic, see knex/knex#1665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants