Refresh assetHash on theme activation #7457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#7423 - asset hashes have never been refreshed properly! - Ghost(Pro)'s 1-theme-only limitation has been hiding this bug for 3 years 馃檮
kirrg001
reviewed
Sep 29, 2016
| @@ -60,6 +60,8 @@ themeHandler = { | |||
|
|
|||
| // clear the view cache | |||
| blogApp.cache = {}; | |||
| // reset the asset hash | |||
| config.assetHash = null; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
tested and works 馃憤 |
yo1dog
pushed a commit
to yo1dog/Ghost
that referenced
this pull request
Oct 14, 2016
closes TryGhost#7423 - asset hashes have never been refreshed properly! - Ghost(Pro)'s 1-theme-only limitation has been hiding this bug for 3 years 馃檮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is YAFPR* for theme refreshes.
Sooo @kevinansfield pointed out to me that the reason people were probably still struggling with theme refreshes is that we don't clear asset hashes on theme activation. I'd been focused on overrides, because they were the new feature.
Theme activation has been a feature forever, but of course, on Ghost(Pro) we limit people to 1 theme at a time, so they have had to upload a new theme (which involved a full restart & cache-clear) in between activations. Clearly no one else is using the power combo of heavy caching & flipping between themes to detect this bug 馃槺
The fix is soooo tiny, I'd really like someone else to take a look at this to see if I'm not missing something else. @kirrg001 & @kevinansfield any thoughts? Reckon I've got it this time? 馃檹
closes #7423
* Fix or Fucking, take your pick 馃榿