🎨 tidy up static id (owner, internal, external) usages #7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs a review before #7495 |
kirrg001
changed the title
kirrg001
force-pushed
the
1.0.0-dev/owner-internal-external-ids
branch
from
1ef9377
to
c450364
Compare
kirrg001
changed the title
kirrg001
force-pushed
the
1.0.0-dev/owner-internal-external-ids
branch
from
c450364
to
a42dcdd
Compare
no issue This PR is an extracted clean up feature of TryGhost#7495. We are using everywhere static id checks (userId === 0 or userId === 1). This PR moves the static values into the Base model. This makes it 1. way more readable and 2. we can change the id's in a central place. I changed the most important occurances - no tests are touched (yet!). The background is: when changing from auto increment id (number) to ObjectId's (string) we still need to support id 1 and 0, because Ghost relies on these two static id's. I would like to support using both: 0/1 as string and 0/1 as number. 1 === owner/internal 0 === external Another important change: User Model does not longer define the contextUser method, because i coulnd't find a reason? I looked in Git history, see TryGhost@6e48275
kirrg001
force-pushed
the
1.0.0-dev/owner-internal-external-ids
branch
from
a42dcdd
to
94fbceb
Compare
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
refs TryGhost#7494, refs TryGhost#7495 This PR is an extracted clean up feature of TryGhost#7495. We are using everywhere static id checks (userId === 0 or userId === 1). This PR moves the static values into the Base model. This makes it 1. way more readable and 2. we can change the id's in a central place. I changed the most important occurrences - no tests are touched (yet!). The background is: when changing from auto increment id (number) to ObjectId's (string) we still need to support id 1 and 0, because Ghost relies on these two static id's. I would like to support using both: 0/1 as string and 0/1 as number. 1 === owner/internal 0 === external Another important change: User Model does not longer define the contextUser method, because i couldn't find a reason? I looked in Git history, see TryGhost@6e48275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
This PR is an extracted clean up feature of #7495.
We are using everywhere static id checks (userId === 0 or userId === 1).
This PR moves the static values into the Base model.
This makes it 1. way more readable and 2. we can change the id's in a central place.
I changed the most important occurances - no tests are touched (yet!).
The background is: when changing from auto increment id (number) to ObjectId's (string) we still need to support id 1 and 0, because Ghost relies on these two static id's.
I would like to support using both: 0/1 as string and 0/1 as number.
1 === owner/internal
0 === external
Another important change:
User Model does not longer define the contextUser method, because i coulnd't find a reason?
I looked in Git history, see 6e48275