🐛 invite permissions for Editor #7724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#7723 - editor role had no permissions assigned for invites
|
Ready for review |
|
In the LTS invite user === add user. Editors had all user permissions, and so would have been able to add a new user. |
You are absolutely right. Thanks |
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
closes TryGhost#7723 - editor role had no permissions assigned for invites
kirrg001
added a commit
to kirrg001/Ghost
that referenced
this pull request
Jan 25, 2017
refs TryGhost#7724 - we already fixed the permissions for the editor - see TryGhost@3d3101a - but as we are inside of a refactoring process, we had two fixtures.json files - we fixed the fixtures.json in the wrong place - now that the permissions are used, we can see failing tests - i have added the correct permissions handling
kevinansfield
pushed a commit
that referenced
this pull request
Jan 25, 2017
refs #7724 - we already fixed the permissions for the editor - see 3d3101a - but as we are inside of a refactoring process, we had two fixtures.json files - we fixed the fixtures.json in the wrong place - now that the permissions are used, we can see failing tests - i have added the correct permissions handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7723
It looks like they were never configured for the editor role.