Removed ghost editor dependency #8137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disordinary
changed the title
disordinary
force-pushed
the
removed-editor
branch
from
36ae66d
to
77f40a0
Compare
disordinary
changed the title
disordinary
commented
Mar 13, 2017
| }; | ||
|
|
||
| var serializer = new SimpleDom.HTMLSerializer([]); | ||
| serializer.serialize(card.render(opts)).should.match('<hr></hr>'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
disordinary
added a commit
to TryGhost/Admin
that referenced
this pull request
Mar 14, 2017
Adds new "card" menus to ghost-admin.i - Navigation with keyboard in both axis. - Search with keyboard in both menus. - Adds a "+" Menu for cards - Adds a "/" Menu for cards - if the block has content and it becomes a markdown or HTML Embed card then the content is included into the card. - Image and HR cards appear below the current section Adds new toolbar with both inline and block styling. Adds a new 'divider' card. Refs: TryGhost/Ghost#8106 Refs: TryGhost/Ghost#7429 Requires: TryGhost/Ghost#8137
disordinary
added a commit
to disordinary/Ghost-Admin
that referenced
this pull request
Mar 14, 2017
Adds new "card" menus to ghost-admin.i - Navigation with keyboard in both axis. - Search with keyboard in both menus. - Adds a "+" Menu for cards - Adds a "/" Menu for cards - if the block has content and it becomes a markdown or HTML Embed card then the content is included into the card. - Image and HR cards appear below the current section Adds new toolbar with both inline and block styling. Adds a new 'divider' card. Refs: TryGhost/Ghost#8106 Refs: TryGhost/Ghost#7429 Requires: TryGhost/Ghost#8137
3 tasks
kevinansfield
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Mar 14, 2017
refs TryGhost/Ghost#8106, TryGhost/Ghost#7429, requires TryGhost/Ghost#8137 -Adds new "card" menus - Navigation with keyboard in both axis. - Search with keyboard in both menus. - Adds a "+" Menu for cards - Adds a "/" Menu for cards - if the block has content and it becomes a markdown or HTML Embed card then the content is included into the card. - Image and HR cards appear below the current section - Adds new toolbar with both inline and block styling. - Adds a new 'divider' card.
Refs TryGhost#7429 ☢️ 👷🏻♀️ This PR removes the dependency on Ghost-Editor and replaces it with the Mobiledoc DOM renderer. It includes new DOM based default cards and atoms.
kevinansfield
force-pushed
the
removed-editor
branch
from
dc9642a
to
b10eef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7429
☢️ 👷🏻♀️ This PR removes the dependency on Ghost-Editor and replaces it with the Mobiledoc DOM renderer. It includes new DOM based default cards and atoms.