Split css server templates #8234

aileen · 2017-03-27T13:11:19Z

closes #8126
needs e3acd3c

This is a replacement PR of #8217 (thanks @TienSFU25 for the work 🤗), because these changes are needed urgently and blocking other work.

Adds a new ghost.css file in /core/shared/ to be used for server side template rendering (error.hbs, subscribe.hbs and private.hbs).

core/server/apps/private-blogging/lib/views/private.hbs

@@ -15,7 +15,7 @@
        <link rel="shortcut icon" href="{{asset "favicon.ico"}}">
        <meta http-equiv="cleartype" content="on">

-        <link rel="stylesheet" href="{{asset "ghost.css" ghost="true" minifyInProduction="true"}}" />


aileen · 2017-03-28T07:31:27Z

I added some logic to getAssetUrl(), to not add /assets/ to the URL, when the ghost.css stylesheet is requested. BUT, I'm not sure if this is the right approach...

ErisDS · 2017-03-29T11:27:02Z

I don't think there was any need to add extra logic here. This is a shared file, so the path passed to the asset helper should be /shared/ghost.css - the line of code in getAssetUrl() that was edited already has logic for this.

See Issue TryGhost#8126 Adds these files under /shared - normalizer.css - error.css - extracted.css (for subscribers.css and private.css) Also makes these files available as public static content

@TienSFU25

closes TryGhost#8126 needs e3acd3c This is a replacement PR of TryGhost#8217 (thanks @TienSFU25 for the whole work 🤗), because these changes are needed urgently and blocking other work. Adds a new `ghost.css` file in `/core/shared/` to be used for server side template rendering (`error.hbs`, `subscribe.hbs` and `private.hbs`).

aileen · 2017-04-04T05:27:57Z

This is ready for review and merge 🎉

kirrg001

This LTGM now 👍

kirrg001 self-assigned this Mar 27, 2017

kirrg001 reviewed Mar 27, 2017

View reviewed changes

aileen force-pushed the split-css-server-templates branch 2 times, most recently from 7375dca to 185d957 Compare March 28, 2017 07:29

Remove default template dependency on client side CSS

00e3aef

See Issue TryGhost#8126 Adds these files under /shared - normalizer.css - error.css - extracted.css (for subscribers.css and private.css) Also makes these files available as public static content

aileen force-pushed the split-css-server-templates branch 2 times, most recently from 24619b8 to ebc436a Compare April 4, 2017 04:57

aileen force-pushed the split-css-server-templates branch from ebc436a to 6dccfda Compare April 4, 2017 05:01

kirrg001 approved these changes Apr 4, 2017

View reviewed changes

ErisDS merged commit e06547a into TryGhost:master Apr 4, 2017

ErisDS mentioned this pull request Apr 5, 2017

Remove default template dependency on client side CSS #8217

Closed

aileen deleted the split-css-server-templates branch October 13, 2017 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split css server templates #8234

Split css server templates #8234

aileen commented Mar 27, 2017

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

aileen commented Mar 28, 2017

ErisDS commented Mar 29, 2017

aileen commented Apr 4, 2017

kirrg001 left a comment

Split css server templates #8234

Split css server templates #8234

Conversation

aileen commented Mar 27, 2017

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

aileen commented Mar 28, 2017

ErisDS commented Mar 29, 2017

aileen commented Apr 4, 2017

kirrg001 left a comment

Choose a reason for hiding this comment