Moved published_at creation to fixtures/utils
#8595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aileen
force-pushed
the
1.0.0-dev/fix-post-fixtures-published-date
branch
from
fc360c2
to
2f9c256
Compare
kirrg001
reviewed
Jun 26, 2017
core/test/unit/migration_spec.js
Outdated
| // Clone the fixtures as they get changed during the migration. | ||
| // The initial blog posts will be added a `published_at` property, which | ||
| // would change the fixturesHash. | ||
| fixtures = _.cloneDeep(fixtures); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
force-pushed
the
1.0.0-dev/fix-post-fixtures-published-date
branch
3 times, most recently
from
a06f8b9
to
9e47c7d
Compare
no issue follow-up from TryGhost#8573 Move the hack that creates `published_at` values from the migration fn to our fixture util.
aileen
force-pushed
the
1.0.0-dev/fix-post-fixtures-published-date
branch
from
9e47c7d
to
3a7ef79
Compare
|
@kirrg001 Is this now good to merge? |
kirrg001
approved these changes
Sep 19, 2017
kirrg001
changed the title
published_at creation to fixtures/utilspublished_at creation to fixtures/utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
follow-up from #8573
Move the hack that creates
published_atvalues from the migration fn to our fixture util.